chore: give build instructions to docs.rs #3952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3952 +/- ##
==========================================
- Coverage 57.07% 57.02% -0.06%
==========================================
Files 193 193
Lines 43041 43041
==========================================
- Hits 24566 24543 -23
- Misses 18475 18498 +23 ☔ View full report in Codecov by Sentry. |
dpc
approved these changes
Dec 15, 2023
justinmoon
approved these changes
Dec 15, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3946 and hopefully makes docs.rs work. See how e.g.
fedimintdfails to build and thus doesn't have docs shown: https://docs.rs/crate/fedimintd/0.2.0/builds/1062229I added the meta field to all crates that might remotely depend on something in Fedimint that uses the task builder. I probably over-did it a bit, but it shouldn't hurt and once #3951 is fixed we can roll it back anyway.