fix(client): missing expiry time #3955
Conversation
| let invoice_since_epoch = invoice.duration_since_epoch() + TOLERANCE; | ||
| if now_since_epoch > invoice_since_epoch { | ||
| let invoice_expiration_epoch = | ||
| invoice.duration_since_epoch() + invoice.expiry_time() + TOLERANCE; |
There was a problem hiding this comment.
thought: So here we add "duration" + "time" + "tolerance (duration)", so what's confusing is that (I guess, expiry_time is "duration", while duration_since_epoch is actually "(absolute) time"). :D.
| if now_since_epoch > invoice_since_epoch { | ||
| let invoice_expiration_epoch = | ||
| invoice.duration_since_epoch() + invoice.expiry_time() + TOLERANCE; | ||
| if now_since_epoch > invoice_expiration_epoch { |
There was a problem hiding this comment.
thought: And now we call on3e thin _since_epoch and the other _epoch which also seems meh. :D
|
I guess we'll want a quick backport and release of this, as is makes all ln payments have 60s deadlines? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3955 +/- ##
==========================================
- Coverage 57.07% 57.03% -0.05%
==========================================
Files 193 193
Lines 43041 43042 +1
==========================================
- Hits 24566 24547 -19
- Misses 18475 18495 +20 ☔ View full report in Codecov by Sentry. |
| let invoice_since_epoch = invoice.duration_since_epoch() + TOLERANCE; | ||
| if now_since_epoch > invoice_since_epoch { | ||
| let invoice_expiration_epoch = | ||
| invoice.duration_since_epoch() + invoice.expiry_time() + TOLERANCE; |
There was a problem hiding this comment.
thought: BTW. If this 3 lines were in a method, than I think we could have a really tiny unit test that crafts a fake invoice and then checks against values against and after the timeout.
|
Successfully created backport PR for |
No description provided.