Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: latency of internal payments within fed #3964

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

okjodom
Copy link
Contributor

@okjodom okjodom commented Dec 17, 2023

Adds latency test coverage to transactions between two fedimint clients in a federation.
From initial tests, turns out these internal transactions are currently much slower than LN sends / receives!
A follow up here is to investigate and improve internal payments perf

================= RESULTS ==================
REISSUE: min: 1.7s, avg: 1.8s, median: 1.8s, p90: 1.9s, max: 2.0s, sum: 54.1s
LN SEND: min: 2.9s, avg: 3.1s, median: 3.1s, p90: 3.2s, max: 4.4s, sum: 62.8s
LN RECV: min: 1.9s, avg: 2.2s, median: 2.2s, p90: 3.0s, max: 3.1s, sum: 44.1s

FM PAY: min: 4.2s, avg: 4.7s, median: 4.4s, p90: 5.0s, max: 9.4s, sum: 93.5s

closes #3695

@okjodom okjodom requested a review from a team as a code owner December 17, 2023 23:53
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (bc4ccf5) 57.08% compared to head (5761793) 56.95%.

Files Patch % Lines
devimint/src/main.rs 0.00% 32 Missing ⚠️
devimint/src/federation.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3964      +/-   ##
==========================================
- Coverage   57.08%   56.95%   -0.14%     
==========================================
  Files         193      193              
  Lines       43043    43078      +35     
==========================================
- Hits        24572    24533      -39     
- Misses      18471    18545      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@justinmoon
Copy link
Contributor

Nice. @okjodom could you make an issue for the investigation?

@justinmoon justinmoon added this pull request to the merge queue Dec 18, 2023
Merged via the queue into fedimint:master with commit 341e97e Dec 18, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add latency test for internal swap
3 participants