-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent spamming blockchain.info with requests #3969
fix: prevent spamming blockchain.info with requests #3969
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3969 +/- ##
==========================================
- Coverage 57.02% 57.01% -0.01%
==========================================
Files 193 193
Lines 43143 43166 +23
==========================================
+ Hits 24603 24612 +9
- Misses 18540 18554 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second commit is an improvement, the first idk, a bit of complexity for not a whole lot of gain imo.
I think what we've observed was actually caused be accumulating multiple deposit addresses. Created a separate issue in: #3970 |
fecd5fa
to
7d1ac83
Compare
7d1ac83
to
3694237
Compare
On some (most) backends "watch" is a no-op, so we can just call nothing.
Re fedimint#3970, but without persistance
3694237
to
6044193
Compare
} | ||
|
||
unreachable!() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be hit after about 100k years, sgtm.
In some circumstances, possibly triggered by a bug or unrelated failure it seems possible
for us to keep calling blockstream.info (or other electrs/esplora backend) from the autocommit loop.
I identified two orthogonal improvements:
Each of them separately is effectively fixing the problem we witnessed, but both make sense, so I guess makes sense to land both.