Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix nix flake show .# #3973

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Dec 19, 2023

No description provided.

@dpc dpc requested a review from a team as a code owner December 19, 2023 18:24
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (341e97e) 56.94% compared to head (8f98387) 56.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3973   +/-   ##
=======================================
  Coverage   56.94%   56.94%           
=======================================
  Files         193      193           
  Lines       43144    43144           
=======================================
  Hits        24569    24569           
  Misses      18575    18575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinmoon
Copy link
Contributor

justinmoon commented Dec 19, 2023

Tested it locally and it worked for me. cargo audit CI job failing with lots of fedimint-ci-audit> error: couldn't check if the package is yanked: not found: No such crate in crates.io index: so re-ran CI.

Maybe needs rebase to include #3972?

@dpc dpc enabled auto-merge December 19, 2023 19:30
@dpc dpc added this pull request to the merge queue Dec 19, 2023
Merged via the queue into fedimint:master with commit 78db6f6 Dec 19, 2023
19 of 20 checks passed
@dpc dpc deleted the 23-12-19-nix-flake-show-fix branch December 19, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants