Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nix flake update #4005

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Conversation

justinmoon
Copy link
Contributor

Should fix CI for #3997 and #3994

@justinmoon justinmoon requested a review from a team as a code owner January 3, 2024 13:50
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c64aa0e) 57.00% compared to head (c4464bb) 57.00%.

❗ Current head c4464bb differs from pull request most recent head 79f4dab. Consider uploading reports for the commit 79f4dab to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4005   +/-   ##
=======================================
  Coverage   57.00%   57.00%           
=======================================
  Files         193      193           
  Lines       43326    43326           
=======================================
  Hits        24697    24697           
  Misses      18629    18629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinmoon
Copy link
Contributor Author

Didn't work. Could use some help here @dpc.

@justinmoon
Copy link
Contributor Author

nix flake lock --update-input flakebox/nixpkg fixed it. Thanks @maan2003!

@maan2003 maan2003 added this pull request to the merge queue Jan 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 3, 2024
@elsirion elsirion added this pull request to the merge queue Jan 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 3, 2024
@benthecarman
Copy link
Contributor

Looks like merge for this failed

@okjodom okjodom added this pull request to the merge queue Jan 3, 2024
@okjodom
Copy link
Contributor

okjodom commented Jan 3, 2024

Re-added to the merge queue but this failed run on macos looks very suspect. Did it fail because of the skipped stages?

Merged via the queue into fedimint:master with commit ce2c9c8 Jan 3, 2024
18 checks passed
@justinmoon
Copy link
Contributor Author

justinmoon commented Jan 3, 2024

Looks like merge for this failed

IIRC the MacOS job isn't required because it can be slow / flaky. Is that right @dpc?

@justinmoon
Copy link
Contributor Author

Note: when I updated it re-compiled bitcoind when running nix develop. IIRC we didn't have to manually re-compile bitcoind in the past. Seems like we should be able to just get a bitcoind binary. Perhaps this only happens in MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants