fix: re-register gateway when routing fees are updated #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4020 +/- ##
==========================================
+ Coverage 57.64% 57.68% +0.03%
==========================================
Files 193 193
Lines 42894 42935 +41
==========================================
+ Hits 24728 24768 +40
- Misses 18166 18167 +1 ☔ View full report in Codecov by Sentry. |
m1sterc001guy
force-pushed
the
reregister_routing_fees
branch
from
b1cb027
to
1db3472
Compare
Kodylow
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4013
This change updates the
FederationConfigfor each federation in the gateway and also re-registers the lightning gateway when the routing fees are updated.This PR also gets us most of the way to per-federation routing fees: #3961