chore(ci): upload release artifacts on tag builds

[dpc]

Fix:

"upload artifacts" we already have is not for uploading release artifacts.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59a88ce) 57.68% compared to head (fbad52d) 57.68%.
Report is 14 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4023   +/-   ##
=======================================
  Coverage   57.68%   57.68%           
=======================================
  Files         193      193           
  Lines       42907    42907           
=======================================
  Hits        24750    24750           
  Misses      18157    18157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[elsirion]

I think this will create the GH release by itself? That way we don't have as much control over the release text etc. and might forget to fix it up later. Could we at least add a good automatic change log generator because this will prevent me from using GitHub's builtin one?

[dpc]

I think this will create the GH release by itself? That way we don't have as much control over the release text etc. and might forget to fix it up later. Could we at least add a good automatic change log generator because this will prevent me from using GitHub's builtin one?

I'm not sure about the exact behavior, but releases can be edited after the fact, even deleted , set as pre-release, etc. so I don't think it's a big deal.

[m1sterc001guy]

I don't have much experience with this myself but looks good as far as I can tell

[fedimint-backports]

Git push to origin failed for releases/v0.2 with exitcode 1