-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Only load federation clients when gateway boots #4026
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4026 +/- ##
==========================================
+ Coverage 58.28% 58.38% +0.09%
==========================================
Files 193 193
Lines 42580 42552 -28
==========================================
+ Hits 24819 24842 +23
+ Misses 17761 17710 -51 ☔ View full report in Codecov by Sentry. |
7b71ee8
to
1588620
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but someone that understands lngateway should look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed and tested 1588620 looks good to me
f0dfacc
to
027bea8
Compare
027bea8
to
e8b9670
Compare
e8b9670
to
e52d9ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See #3781 (comment) for context.
DatabaseSource
lnrpc
behind a wrapper function that first checks if the lightning node is connected to the gateway.