Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Relative path of root README.md #4038

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

15IITian
Copy link
Contributor

@15IITian 15IITian commented Jan 15, 2024

Added the relative path of root README.md file to those Crate's Cargo.toml which do not have its own README
#3924

@15IITian 15IITian requested review from a team as code owners January 15, 2024 14:31
Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meta data isn't really needed for unpublished crates, so I think we should just not touch their Cargo.tomls. Otherwise looks good :)

readme = "../README.md"
publish = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really needed for Cargo.tomls with publish=false since they aren't published to crates.io

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK , I'll remove them from such Cargo.toml.

@15IITian 15IITian marked this pull request as draft January 15, 2024 15:45
@15IITian 15IITian marked this pull request as ready for review January 15, 2024 16:26
elsirion
elsirion previously approved these changes Jan 16, 2024
Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: normally you don't undo changes from earlier commits in later ones, but would rather edit old commits and force-push.

Feel free to fix it, I'll re-ACK, but it's not a huge deal here since the PR is very small.

@15IITian 15IITian marked this pull request as draft January 16, 2024 16:31
@15IITian 15IITian marked this pull request as ready for review January 17, 2024 04:33
@15IITian 15IITian requested a review from a team as a code owner January 17, 2024 04:33
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a20e32) 58.21% compared to head (07aed99) 58.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4038      +/-   ##
==========================================
+ Coverage   58.21%   58.23%   +0.02%     
==========================================
  Files         193      193              
  Lines       42580    42580              
==========================================
+ Hits        24787    24797      +10     
+ Misses      17793    17783      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maan2003
Copy link
Member

needs rebase

@15IITian 15IITian marked this pull request as draft January 17, 2024 08:58
@15IITian 15IITian marked this pull request as draft January 17, 2024 08:58
@15IITian 15IITian marked this pull request as draft January 17, 2024 08:58
@15IITian 15IITian marked this pull request as draft January 17, 2024 08:58
@15IITian 15IITian closed this Jan 17, 2024
@15IITian 15IITian deleted the relative_README branch January 17, 2024 09:10
@15IITian 15IITian restored the relative_README branch January 17, 2024 09:10
@15IITian 15IITian reopened this Jan 17, 2024
@15IITian
Copy link
Contributor Author

15IITian commented Jan 17, 2024

needs rebase

@maan2003 I am not getting how to solve this problem -> kindly please help me out .

@elsirion
Copy link
Contributor

elsirion commented Jan 17, 2024

Idk how you even got into this state, but copying the commit hashes of the commits you actually want, a hard reset on an up-to-date master and then cherry-picking is probably the fastest way to fix it. You can find some documentation on how to use git here https://git-scm.com/

Screenshot 2024-01-17 at 16-57-36 chore add Relative path of root README md by 15IITian · Pull Request #4038 · fedimint_fedimint

@15IITian
Copy link
Contributor Author

15IITian commented Jan 17, 2024

Idk how you even got into this state.

I think ,It was my fault as after successfully editing the older commits (to solve that unpublished crate issue which was merged ) in this branch by interactive rebase -> By mistake , I rebase this branch (not the master branch) and then push all the work .
Therefore , it is showing all the commits which are just after that commit .

@15IITian
Copy link
Contributor Author

15IITian commented Jan 17, 2024

Idk how you even got into this state, but copying the commit hashes of the commits you actually want, a hard reset on an up-to-date master and then cherry-picking is probably the fastest way to fix it. You can find some documentation on how to use git here https://git-scm.com/

Ok

@15IITian 15IITian closed this Jan 18, 2024
@15IITian 15IITian deleted the relative_README branch January 18, 2024 06:51
@15IITian 15IITian restored the relative_README branch January 18, 2024 07:43
@15IITian 15IITian reopened this Jan 18, 2024
Added the relative path of root README.md file to those publishable Crate's Cargo.toml which do not have its own
README
@15IITian 15IITian marked this pull request as ready for review January 18, 2024 07:53
@15IITian
Copy link
Contributor Author

Idk how you even got into this state

I got the problem:
I was trying to edit merged PR' commit which causes to reopen rest other merged PR's as it changes its commit hash :
Screenshot from 2024-01-18 09-48-38

@elsirion
Copy link
Contributor

The audit CI error isn't your fault.

@dpc dpc added this pull request to the merge queue Jan 19, 2024
Merged via the queue into fedimint:master with commit 021d8fe Jan 19, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants