-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Relative path of root README.md #4038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meta data isn't really needed for unpublished crates, so I think we should just not touch their Cargo.toml
s. Otherwise looks good :)
fedimint-wasm-tests/Cargo.toml
Outdated
readme = "../README.md" | ||
publish = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really needed for Cargo.toml
s with publish=false
since they aren't published to crates.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK , I'll remove them from such Cargo.toml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: normally you don't undo changes from earlier commits in later ones, but would rather edit old commits and force-push.
Feel free to fix it, I'll re-ACK, but it's not a huge deal here since the PR is very small.
2f756d3
to
8e0ee8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4038 +/- ##
==========================================
+ Coverage 58.21% 58.23% +0.02%
==========================================
Files 193 193
Lines 42580 42580
==========================================
+ Hits 24787 24797 +10
+ Misses 17793 17783 -10 ☔ View full report in Codecov by Sentry. |
needs rebase |
@maan2003 I am not getting how to solve this problem -> kindly please help me out . |
Idk how you even got into this state, but copying the commit hashes of the commits you actually want, a hard reset on an up-to-date master and then cherry-picking is probably the fastest way to fix it. You can find some documentation on how to use git here https://git-scm.com/ |
I think ,It was my fault as after successfully editing the older commits (to solve that unpublished crate issue which was merged ) in this branch by |
Ok |
Added the relative path of root README.md file to those publishable Crate's Cargo.toml which do not have its own README
a78b65f
to
07aed99
Compare
The audit CI error isn't your fault. |
Added the relative path of root README.md file to those Crate's Cargo.toml which do not have its own README
#3924