Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc strings to gateway/ln-gateway/src/bin/gatewayd.rs #4063

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

okjodom
Copy link
Contributor

@okjodom okjodom commented Jan 18, 2024

  • Adds and updates doc strings in gatewayd.rs
  • Updates description in ln-gateway/Cargo.toml. We had a very old description!

@okjodom okjodom requested a review from a team as a code owner January 18, 2024 18:00
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (47eb296) 58.07% compared to head (e689e4c) 58.08%.

Files Patch % Lines
gateway/ln-gateway/src/bin/gatewayd.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4063      +/-   ##
==========================================
+ Coverage   58.07%   58.08%   +0.01%     
==========================================
  Files         197      197              
  Lines       43700    43700              
==========================================
+ Hits        25378    25385       +7     
+ Misses      18322    18315       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

m1sterc001guy
m1sterc001guy previously approved these changes Jan 19, 2024
@okjodom okjodom requested a review from a team January 19, 2024 08:11
@dpc dpc added this pull request to the merge queue Feb 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2024
elsirion
elsirion previously approved these changes Feb 7, 2024
@elsirion elsirion added this pull request to the merge queue Feb 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 7, 2024
@elsirion
Copy link
Contributor

elsirion commented Feb 8, 2024

Nees rebase :(

@okjodom
Copy link
Contributor Author

okjodom commented Feb 8, 2024

Rebased :)

@justinmoon justinmoon added this pull request to the merge queue Feb 9, 2024
Merged via the queue into fedimint:master with commit 1738332 Feb 9, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants