refactor: client error handling #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4064 +/- ##
==========================================
- Coverage 58.34% 58.31% -0.04%
==========================================
Files 194 194
Lines 42618 42644 +26
==========================================
+ Hits 24865 24867 +2
- Misses 17753 17777 +24 ☔ View full report in Codecov by Sentry. |
dpc
force-pushed
the
24-01-18-redo-error-handling
branch
from
33cad7b
to
a984553
Compare
elsirion
previously approved these changes
Jan 19, 2024
There was a problem hiding this comment.
I think this is a good direction to go. We'll need to build tooling to either detect zombie state machines or always include timeout state transitions to not overload the executor, but that sounds doable.
I'll ACK to reduce latency, but please take a look at my one comment.
dpc
force-pushed
the
24-01-18-redo-error-handling
branch
from
e82f103
to
10b0508
Compare
elsirion
previously approved these changes
Jan 23, 2024
After thinking about fedimint#4051 and discussion inside it, it seems to me that `is_retryable` is just a terrible pattern, so in this change: * get rid of `is_retryable` * make all federation errors retryable * add function to report only errors that is somewhat important * go over callsites and do something (hopefully) better
maan2003
force-pushed
the
24-01-18-redo-error-handling
branch
from
10b0508
to
7ad74ab
Compare
|
rebased |
maan2003
approved these changes
Jan 23, 2024
Merged
justinmoon
approved these changes
Jan 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jan 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After thinking about #4051 and discussion inside it, it seems to me that
is_retryableis just a terrible pattern, so in this change:is_retryable