feat: await_block LRU cache (non-global) #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
commented
Jan 19, 2024
| @@ -360,15 +385,6 @@ pub trait GlobalFederationApi { | |||
|
|
|||
| async fn await_transaction(&self, txid: TransactionId) -> FederationResult<TransactionId>; | |||
|
|
|||
| async fn await_output_outcome<R>( | |||
There was a problem hiding this comment.
Not object safe so had be kicked out (to impl DynGlobalApi).
dpc
force-pushed
the
24-01-19-24-01-15-recovery-caching-non-global
branch
from
fa0419e
to
b68a820
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4080 +/- ##
==========================================
- Coverage 58.27% 58.09% -0.19%
==========================================
Files 192 192
Lines 42682 42972 +290
==========================================
+ Hits 24873 24964 +91
- Misses 17809 18008 +199 ☔ View full report in Codecov by Sentry. |
dpc
force-pushed
the
24-01-19-24-01-15-recovery-caching-non-global
branch
3 times, most recently
from
09d8f03
to
4634780
Compare
3 tasks
elsirion
reviewed
Jan 24, 2024
dpc
force-pushed
the
24-01-19-24-01-15-recovery-caching-non-global
branch
from
4634780
to
4c4e9da
Compare
dpc
force-pushed
the
24-01-19-24-01-15-recovery-caching-non-global
branch
from
4c4e9da
to
3bbb35d
Compare
|
@elsirion ✔️ ❓ 🙏 🤣 |
elsirion
previously approved these changes
Jan 26, 2024
maan2003
previously approved these changes
Jan 26, 2024
fedimint-core/src/api.rs
Outdated
|
|
||
| // but multiple request for the same `block_index` will serialize on the | ||
| // per-index lock, avoiding doing the same work | ||
| let mut block_lock = block_entry_arc.lock().await; |
There was a problem hiding this comment.
block_entry can be a OnceCell
https://docs.rs/tokio/latest/tokio/sync/struct.OnceCell.html
There was a problem hiding this comment.
i pushed 2db867d to reduce review cycles
maan2003
previously approved these changes
Jan 26, 2024
maan2003
force-pushed
the
24-01-19-24-01-15-recovery-caching-non-global
branch
from
4efb0f2
to
2db867d
Compare
maan2003
approved these changes
Jan 26, 2024
elsirion
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #4035 and #4042.
This is a version #4046 without global statics.
Wasm couldn't handle
lazy_static, and globals are icky. The price is wrangling with an already overly complicated set of traits in this area.