chore(fedimint-cli): convert invalid JSON data to JSON string #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4088 +/- ##
==========================================
+ Coverage 58.32% 58.36% +0.04%
==========================================
Files 192 192
Lines 42646 42655 +9
==========================================
+ Hits 24872 24895 +23
+ Misses 17774 17760 -14 ☔ View full report in Codecov by Sentry. |
maan2003
reviewed
Jan 22, 2024
15IITian
changed the title
JSON data to JSON string
15IITian
changed the title
JSON data to JSON string
GetPsyched
reviewed
Jan 23, 2024
|
Please mark each review as resolved after you've added the suggested changes; it clutters the PR view for future reviews and/or reviewers. |
maan2003
reviewed
Jan 23, 2024
elsirion
previously approved these changes
Jan 24, 2024
If `params` fails to get parsed into JSON -> then convert it into `JSON String`
Added debug statement to tell that if given params data is not seriazable , then converting it into JSON string
elsirion
approved these changes
Jan 25, 2024
IYDM , Should I solve it in this PR ? |
|
I don't think it's solvable without creating other edge-cases. |
|
Ok |
dpc
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
paramsfails to get parsed into JSON -> then convert it into validJSON Stringwrapped inValue::Stringfix #3194