chore: Client Database Migrations (without state machine migrations)

[m1sterc001guy]

Step 1 of #3417

This PR adds the equivalent tests and functions for client db migrations that the server side has.

Best to review this PR per commit, each module is a separate commit.

State machine db migrations will come next.

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ba49027) 58.36% compared to head (7ee0d4a) 58.16%.
Report is 47 commits behind head on master.

Files	Patch %	Lines
fedimint-client/src/lib.rs	90.90%	2 Missing ⚠️
modules/fedimint-dummy-client/src/db.rs	75.00%	2 Missing ⚠️
modules/fedimint-dummy-client/src/lib.rs	75.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4103      +/-   ##
==========================================
- Coverage   58.36%   58.16%   -0.21%     
==========================================
  Files         192      192              
  Lines       42646    43034     +388     
==========================================
+ Hits        24890    25029     +139     
- Misses      17756    18005     +249     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dpc]

Generally LGTM, with some minor comments.

One thing that it's not doing is touching active executor states. Do you think it's not neccessary (because meta on it is serialized in json, so it can be somewhat gradually handled?)

Video of my review: https://youtu.be/IwAWRa889jA

[m1sterc001guy]

Thanks for the review!

One thing that it's not doing is touching active executor states. Do you think it's not neccessary (because meta on it is serialized in json, so it can be somewhat gradually handled?)

Nope, I think this does need to be handled. I just wanted to do it in a separate PR since this one was rather big already.

[dpc]

Big recovery refactor landed, good time to rebase and land.

[m1sterc001guy]

I added the MintRecoveryState to the mint migration test and did my best to populate as much of it as possible. I had to make some things public that were previously only within the crate or private, hopefully this is an acceptable tradeoff for having migration coverage

[elsirion]

Not the cleanest commit history, but an important step towards client version migrations 🎉

[elsirion]

I'm ok with making this pub, but is there a reason for migration tests not to live in their respective crate (client or server)? We mainly have the tests crates for integration-testing client and server together.

[m1sterc001guy]

I originally did it just so all of the migration tests were in the same spot, but now I'm somewhat regretting it as it made me change all of these things to pub. Would you prefer if I moved them back? Probably best done in a separate PR

[elsirion]

I agree it's not worth uprooting this PR. Let's try to tidy up public interfaces in a separate PR. Not super high priority.

[m1sterc001guy]

Will leave this for now and handle in separate PR