-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use fedimint-aleph-bft #4116
Conversation
I didn't use async |
I think using BackupReader would allow for a cleaner implementation with a second UnitReader struct and two separate constructors instead of the load_session method that now returns both, but we can also leave it until we upstreamed the change. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4116 +/- ##
==========================================
- Coverage 58.37% 58.32% -0.06%
==========================================
Files 192 192
Lines 42659 42646 -13
==========================================
- Hits 24904 24873 -31
- Misses 17755 17773 +18 ☔ View full report in Codecov by Sentry. |
I attempted this, we still need to find initial |
b172e74
to
bb15908
Compare
fixes #4054