Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use fedimint-aleph-bft #4116

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

maan2003
Copy link
Member

fixes #4054

@maan2003 maan2003 requested review from a team as code owners January 24, 2024 09:25
@maan2003
Copy link
Member Author

I didn't use async BackupReader because we use Cursor<Vec<u8>> which is fine to read in async code.

@joschisan
Copy link
Contributor

I didn't use async BackupReader because we use Cursor<Vec<u8>> which is fine to read in async code.

I think using BackupReader would allow for a cleaner implementation with a second UnitReader struct and two separate constructors instead of the load_session method that now returns both, but we can also leave it until we upstreamed the change.

joschisan
joschisan previously approved these changes Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3ab7dce) 58.37% compared to head (bb15908) 58.32%.

Files Patch % Lines
fedimint-server/src/atomic_broadcast/backup.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4116      +/-   ##
==========================================
- Coverage   58.37%   58.32%   -0.06%     
==========================================
  Files         192      192              
  Lines       42659    42646      -13     
==========================================
- Hits        24904    24873      -31     
- Misses      17755    17773      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maan2003
Copy link
Member Author

two separate constructors instead of the load_session method

I attempted this, we still need to find initial units_index for UnitSaver, for which we have to check the entire old units

@maan2003 maan2003 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into fedimint:master with commit 116faaf Jan 24, 2024
20 checks passed
@maan2003 maan2003 deleted the fedimint-aleph-bft branch January 24, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnitSaver::flush is using wrong block_on?
3 participants