feat: expose pending accepted items in api for recovery and debugging. #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4133 +/- ##
==========================================
- Coverage 58.35% 58.30% -0.06%
==========================================
Files 194 192 -2
Lines 42581 42725 +144
==========================================
+ Hits 24847 24909 +62
- Misses 17734 17816 +82 ☔ View full report in Codecov by Sentry. |
elsirion
approved these changes
Jan 25, 2024
maan2003
approved these changes
Jan 25, 2024
Merged
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dpc
added a commit
to dpc/fedimint
that referenced
this pull request
Jan 27, 2024
In this change: I add a new endpoint for getting session outcomes, without blocking on them. The `await_` version is nice and all, but sometimes awaiting is a PITA, because you might get stuck. Then I use it to build a `get_session_outcome_or_pending_items` method, that is building on top of `pending_accepted_items` endpoint from fedimint#4133 The problem with `pending_accepted_items` is that it doesn't return any info about which block is actually being built, so it's inherently racy. Then I use it in recovery code to not get stuck waiting for the current session to finish. I feel like there might be some architecturally bette ways to achive things, but it's friday evening, so might as well push it and let people provide some feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.