fix: recognise vetted gateways configured in base meta #4138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4138 +/- ##
==========================================
- Coverage 58.29% 58.04% -0.25%
==========================================
Files 192 197 +5
Lines 42708 43722 +1014
==========================================
+ Hits 24896 25379 +483
- Misses 17812 18343 +531 ☔ View full report in Codecov by Sentry. |
elsirion
previously approved these changes
Jan 26, 2024
okjodom
force-pushed
the
vgw
branch
2 times, most recently
from
7cd7c87
to
501d7b8
Compare
elsirion
reviewed
Jan 30, 2024
- fedimint clients would only recognise [vetted gateways meta] field if configured via meta override url. This change allows clients to also read the same meta field on the base meta config
elsirion
approved these changes
Feb 9, 2024
justinmoon
approved these changes
Feb 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin releases/v0.2
git worktree add -d .worktree/backport-4138-to-releases/v0.2 origin/releases/v0.2
cd .worktree/backport-4138-to-releases/v0.2
git switch --create backport-4138-to-releases/v0.2
git cherry-pick -x 13a54346c3ebb5d63df4f735316a4be70b0afc64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedimint clients would only recognise [vetted gateways meta] field if configured via meta override url. This change allows clients to also read the same meta field on the base meta config. vetted gateways meta value from
meta_override_urlis preferred over value supplied from the base meta.