Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable discord alerts for backwards-compatibility #4139

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

bradleystachurski
Copy link
Member

The discord alerts channel is too noisy with these alerts, especially while we know there are outstanding fixes.

@bradleystachurski bradleystachurski requested a review from a team as a code owner January 26, 2024 14:50
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04d32a7) 58.06% compared to head (56c6dc6) 58.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4139   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files         192      192           
  Lines       42972    42972           
=======================================
  Hits        24951    24951           
  Misses      18021    18021           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elsirion elsirion added this pull request to the merge queue Jan 27, 2024
Merged via the queue into fedimint:master with commit 9a8c180 Jan 27, 2024
20 of 21 checks passed
@bradleystachurski bradleystachurski deleted the disable-alert branch January 27, 2024 13:25
@justinmoon
Copy link
Contributor

Do we plan to re-enable them in the future?

@bradleystachurski
Copy link
Member Author

Do we plan to re-enable them in the future?

Yep 👍

I think a sane approach is:

  1. re-enable once all backwards-compatibility tests are fixed (only outstanding PR)
  2. once CI runs fast enough, make the workflow required to pass before merging

Does that sound reasonable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants