Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore TracingSetup error in migration tests #4146

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

m1sterc001guy
Copy link
Contributor

Running cargo test causes an error with the db migration tests since the tracing subscriber is already setup. Simple fix is just to ignore the error.

@m1sterc001guy m1sterc001guy requested review from a team as code owners January 26, 2024 20:24
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04d32a7) 58.06% compared to head (471e699) 58.02%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4146      +/-   ##
==========================================
- Coverage   58.06%   58.02%   -0.04%     
==========================================
  Files         192      192              
  Lines       42972    42982      +10     
==========================================
- Hits        24951    24942       -9     
- Misses      18021    18040      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, did this lead to flakiness?

@elsirion elsirion added this pull request to the merge queue Jan 27, 2024
Merged via the queue into fedimint:master with commit 41f2ada Jan 27, 2024
21 of 22 checks passed
@dpc
Copy link
Contributor

dpc commented Jan 27, 2024

Sounds reasonable, did this lead to flakiness?

@elsirion Makes cargo test fail. CI is fine because cargo nextest we're using spawns every test in a different process (that's the secret sauce of it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants