fix: remove racy endpoint PENDING_ACCEPTED_ITEMS_ENDPOINT for SESSION_STATUS_ENDPOINT

[joschisan]

No description provided.

[dpc]

I think it's an improvement, but one problem with this is that the result can't be cached.

If the response included some flag if this session is closed or not the it could (when closed). Then just getting the block, without awaiting it would be entirely redundant.

[codecov]

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (a099fff) 58.30% compared to head (407ff05) 58.15%.
Report is 40 commits behind head on master.

Files	Patch %	Lines
fedimint-server/src/net/api.rs	13.33%	13 Missing ⚠️
fedimint-core/src/session_outcome.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4150      +/-   ##
==========================================
- Coverage   58.30%   58.15%   -0.15%     
==========================================
  Files         192      192              
  Lines       42757    43161     +404     
==========================================
+ Hits        24928    25100     +172     
- Misses      17829    18061     +232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dpc]

❤️

[elsirion]

Do we actually need to cache this? I'd imagine to only use this endpoint for the last session we want to fetch. I think that's lower complexity overall than trying to adapt the cache to potentially non-final responses.

EDIT: otherwise we'd also need to optionally return signatures here to avoid fetching from multiple guardians, which would make this even more complex and would possibly require a new query strategy.

[elsirion]

LGTM

[elsirion]

Also needs backporting since the previous version was backported too #4134 and we don't want two different APIs to live on in the next release.

@dpc don't we also have to bump the minor API version here?

[dpc]

@dpc don't we also have to bump the minor API version here?

Right.

[maan2003]

approving based on past approvals

[fedimint-backports]

Successfully created backport PR for releases/v0.2:

• [Backport releases/v0.2] fix: remove racy endpoint PENDING_ACCEPTED_ITEMS_ENDPOINT for SESSION_STATUS_ENDPOINT #4180

[elsirion]

I get the feeling we should also document when an API was introduced and enforce that via CI somehow. Otherwise it will be fairly hard to figure out later on.

[dpc]

I get the feeling we should also document when an API was introduced and enforce that via CI somehow.

Semgrep rule to put a specially formatted comment on every api_endpoint!?

Or maybe just an extra argument to the macro... @elsirion

Edit: Let's move #4190