refactor: remove unused error paths, use expect when possible #4154
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4154 +/- ##
==========================================
- Coverage 58.30% 58.04% -0.26%
==========================================
Files 192 192
Lines 42757 42972 +215
==========================================
+ Hits 24928 24942 +14
- Misses 17829 18030 +201 ☔ View full report in Codecov by Sentry. |
| .tier(&created.amount) | ||
| .expect("We obtained this amount from tbs_pks when we created the output"); | ||
|
|
||
| // this implies that the mint client config's public keys are inconsistent |
There was a problem hiding this comment.
So maybe in the future we can just check config consistency when joining the federation and then expect here?
| @@ -185,6 +185,14 @@ fn lagrange_multipliers(scalars: Vec<Scalar>) -> Vec<Scalar> { | |||
| .collect() | |||
| } | |||
|
|
|||
| pub fn verify_blinded_signature( | |||
There was a problem hiding this comment.
Some docs might be useful here for everything that isnt familiar with the pairing crypto
| let agg_blind_signature = aggregate_signature_shares( | ||
| &blinded_signature_shares | ||
| .into_iter() | ||
| .map(|(peer, share)| (peer.to_usize() as u64 + 1, share)) |
There was a problem hiding this comment.
+1 here is just to prevent a peer with id 0?
There was a problem hiding this comment.
We need the +1 here so the cryptography checks out.
There was a problem hiding this comment.
I knew what it was for but also raised an eye brow that there is no fn to convert the peer ID. But that's how I wrote it an eternity ago and Joscha just kept it that way.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
No description provided.