Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add bitcoind to 0.2.1 mutinynet docker compose #4164

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Jan 29, 2024

Fix, adds bitcoind mutinynet in docker compose, removed it when I was updating docker for 0.2.1 and used api

@Kodylow Kodylow requested a review from a team as a code owner January 29, 2024 19:51
@Kodylow Kodylow changed the title fix: bitcoind docker 0.2.1 fix: add bitcoind to 0.2.1 mutinynet docker compose Jan 29, 2024
@elsirion
Copy link
Contributor

Was the mutiny socker setup just broken in the meantime?

@Kodylow
Copy link
Member Author

Kodylow commented Jan 30, 2024

Yeah, if you run the docker compose as is it errors bc lnd has a depends on bitcoind, this fixes it

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8ead74) 58.17% compared to head (4bf2aee) 58.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4164   +/-   ##
=======================================
  Coverage   58.17%   58.17%           
=======================================
  Files         192      192           
  Lines       43225    43225           
=======================================
  Hits        25145    25145           
  Misses      18080    18080           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elsirion elsirion requested a review from douglaz January 31, 2024 09:58
@justinmoon justinmoon added this pull request to the merge queue Jan 31, 2024
Merged via the queue into fedimint:master with commit 58717cb Jan 31, 2024
21 checks passed
@justinmoon justinmoon deleted the fix-gateway-compose branch January 31, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants