fix: bump retry count for test_gateway_configuration #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleystachurski
force-pushed
the
fix-gateway-config-test
branch
from
0d068b0
to
bc5df0b
Compare
justinmoon
previously approved these changes
Jan 30, 2024
maan2003
previously approved these changes
Jan 30, 2024
elsirion
previously approved these changes
Jan 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4172 +/- ##
==========================================
+ Coverage 58.04% 58.14% +0.09%
==========================================
Files 192 192
Lines 43006 43156 +150
==========================================
+ Hits 24962 25092 +130
- Misses 18044 18064 +20 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
CI is very flaky rn. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
fix: bump retry count for test_gateway_configuration
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bradleystachurski
dismissed stale reviews from elsirion, maan2003, and justinmoon
via
215b5cd
bradleystachurski
force-pushed
the
fix-gateway-config-test
branch
from
bc5df0b
to
215b5cd
Compare
|
15 seconds was still causing failures in the merge queue, so bumped to 30 🤷 https://github.com/fedimint/fedimint/actions/runs/7711375688/job/21016618874#step:6:1867 |
elsirion
approved these changes
Jan 31, 2024
justinmoon
approved these changes
Jan 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web server is restarting so we may need to wait a bit longer. Multiple code coverage CI failures due to this.
https://github.com/fedimint/fedimint/actions/runs/7704054812/job/20995614440?pr=4169#step:6:1719