Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better gatewayd logs #4175

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Better gatewayd logs #4175

merged 3 commits into from
Jan 30, 2024

Conversation

maan2003
Copy link
Member

fixes #4165
based on #4174

@maan2003 maan2003 requested review from a team as code owners January 30, 2024 10:20
@maan2003 maan2003 marked this pull request as draft January 30, 2024 10:21
@maan2003 maan2003 marked this pull request as ready for review January 30, 2024 10:40
fedimint-core/src/util/mod.rs Show resolved Hide resolved
Copy link
Contributor

@m1sterc001guy m1sterc001guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m1sterc001guy m1sterc001guy added this pull request to the merge queue Jan 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2024
@maan2003 maan2003 added this pull request to the merge queue Jan 30, 2024
Merged via the queue into fedimint:master with commit 660e35e Jan 30, 2024
21 checks passed
@maan2003 maan2003 deleted the better-gwd-lg branch January 30, 2024 19:21
@fedimint-backports
Copy link

Backport failed for releases/v0.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin releases/v0.2
git worktree add -d .worktree/backport-4175-to-releases/v0.2 origin/releases/v0.2
cd .worktree/backport-4175-to-releases/v0.2
git switch --create backport-4175-to-releases/v0.2
git cherry-pick -x 3ce9a5a6a380c03d613335190b5f7af7f2945d33 d4858d43141be2b8a7425ab53d22214bb72c416a 24c3eef191b75a9f7b8b053c7dff8a71a769894f

@github-actions github-actions bot mentioned this pull request Jan 30, 2024
@maan2003
Copy link
Member Author

looks like backports port is just bad now

@elsirion
Copy link
Contributor

We probably just diverged too much already, still good for opening issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway logs should include federation_id as context
4 participants