-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better gatewayd logs #4175
Merged
Merged
Better gatewayd logs #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maan2003
force-pushed
the
better-gwd-lg
branch
from
January 30, 2024 10:36
4db2844
to
24c3eef
Compare
elsirion
approved these changes
Jan 30, 2024
m1sterc001guy
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 30, 2024
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin releases/v0.2
git worktree add -d .worktree/backport-4175-to-releases/v0.2 origin/releases/v0.2
cd .worktree/backport-4175-to-releases/v0.2
git switch --create backport-4175-to-releases/v0.2
git cherry-pick -x 3ce9a5a6a380c03d613335190b5f7af7f2945d33 d4858d43141be2b8a7425ab53d22214bb72c416a 24c3eef191b75a9f7b8b053c7dff8a71a769894f |
Closed
looks like backports port is just bad now |
We probably just diverged too much already, still good for opening issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4165
based on #4174