Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor devimint into a library #4176

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

maan2003
Copy link
Member

this can be external integrators to run tests with custom modules

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1810 lines in your changes are missing coverage. Please review.

Comparison is base (9016ec3) 58.07% compared to head (c9b035e) 58.05%.
Report is 17 commits behind head on master.

Files Patch % Lines
devimint/src/tests.rs 0.00% 1450 Missing ⚠️
devimint/src/cli.rs 0.00% 224 Missing ⚠️
devimint/src/gatewayd.rs 0.00% 69 Missing ⚠️
devimint/src/devfed.rs 0.00% 54 Missing ⚠️
devimint/src/main.rs 0.00% 6 Missing ⚠️
devimint/src/federation.rs 0.00% 4 Missing ⚠️
devimint/src/lib.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4176      +/-   ##
==========================================
- Coverage   58.07%   58.05%   -0.03%     
==========================================
  Files         192      196       +4     
  Lines       43115    43141      +26     
==========================================
+ Hits        25038    25044       +6     
- Misses      18077    18097      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

this can be external integrators to run tests with custom modules
@maan2003
Copy link
Member Author

for reviewing:
git diff @~:devimint/src/main.rs @:devimint/src/tests.rs

@maan2003 maan2003 marked this pull request as ready for review January 30, 2024 13:48
@maan2003 maan2003 requested a review from a team as a code owner January 30, 2024 13:48
Copy link
Contributor

@dpc dpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@maan2003 maan2003 added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2024
@maan2003 maan2003 added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2024
@dpc dpc added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2024
@dpc dpc added this pull request to the merge queue Jan 31, 2024
Merged via the queue into fedimint:master with commit 5e5bd79 Jan 31, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants