chore: during dkg generate peer-ids by peer name ordering #4178
Conversation
|
Running |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4178 +/- ##
==========================================
- Coverage 58.14% 58.11% -0.03%
==========================================
Files 192 192
Lines 43156 43234 +78
==========================================
+ Hits 25092 25126 +34
- Misses 18064 18108 +44 ☔ View full report in Codecov by Sentry. |
|
@douglaz fyi |
| // in certain (very obscure) cases, it might be worthwhile to sort by urls, so | ||
| // just expose it as an env var; probably no need to document it too much | ||
| if std::env::var_os("FM_PEER_ID_SORT_BY_URL").is_some_and(|var| !var.is_empty()) { |
There was a problem hiding this comment.
Irrespective of this instance not being too important, I feel like we need a more coherent way of managing possible env vars so we can list them in help etc.
There was a problem hiding this comment.
Would an enum listing be appropriate?
There was a problem hiding this comment.
Probably not since modules sometimes define env vars too, lots of things to consider.
There was a problem hiding this comment.
Let's just move them to one (few, if there are crate-dependency needs) file:
const FM_VAR_BLAH_NAME : &str = "....";
and then we can link in the docs where to find them? Least amount of hassle for the benefit given?
(not doing it in this PR).
There was a problem hiding this comment.
Let's move discussion to: #4191
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Will this be backported? |
|
Successfully created backport PR for |
|
@douglaz done |
QoL thing.