fix(justfile): don't use cargo -p
#4184
Conversation
It causes different features/deps being selected, which causes rebuilds of almost whole project, which can be painful. Instead of `cargo test -p pkg` it's better to use `cargo nextest run -E 'package(pkg)'`.
|
@m1sterc001guy fyi |
|
@m1sterc001guy Idea. Should generating migration aferwards run I generated new migration, now I'd like to see if it worked and need to do it manually... |
|
Did a bunch of renaming to unify stuff. I'm open for pushback. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4184 +/- ##
=======================================
Coverage 58.17% 58.17%
=======================================
Files 192 192
Lines 43225 43225
=======================================
+ Hits 25145 25147 +2
+ Misses 18080 18078 -2 ☔ View full report in Codecov by Sentry. |
| @@ -114,7 +114,7 @@ mod fedimint_migration_tests { | |||
| use fedimint_dummy_common::{DummyCommonInit, DummyInput, DummyOutput}; | |||
| use fedimint_dummy_server::Dummy; | |||
| use fedimint_logging::TracingSetup; | |||
| use fedimint_testing::db::{prepare_db_migration_snapshot, validate_migrations, BYTE_32}; | |||
| use fedimint_testing::db::{snapshot_db_migrations, validate_migrations, BYTE_32}; | |||
There was a problem hiding this comment.
I decided to use snapshot as a verb to make it more uniform and shorter.
For development it has been convenient for me to generate the snapshot first, just to confirm that the test was written correctly, then run the validation. While developing its just slightly more confusing to run both at the same time since it takes a tad more work to track down where the problem is. This is just a development workflow though so I can temporarily change the justfile to support that for myself. Your change here is more convenient for everyone else. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
It causes different features/deps being selected, which causes rebuilds of almost whole project, which can be painful.
Instead of
cargo test -p pkgit's better to usecargo nextest run -E 'package(pkg)'.