chore: remove Garbage Collection ;) #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
force-pushed
the
24-02-02-cancer-removal
branch
from
5a73e18
to
c947850
Compare
dpc
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4227 +/- ##
==========================================
- Coverage 57.95% 57.89% -0.07%
==========================================
Files 197 197
Lines 43413 43430 +17
==========================================
- Hits 25161 25143 -18
- Misses 18252 18287 +35 ☔ View full report in Codecov by Sentry. |
I'm a simple developer. I see a "GC" I find the way to get rid of it.
dpc
force-pushed
the
24-02-02-cancer-removal
branch
from
c947850
to
60c3798
Compare
dpc
changed the title
dpc
commented
Feb 3, 2024
| @@ -24,8 +24,9 @@ | |||
| //! interaction is required to drive them forward. | |||
| //! | |||
| //! ### State Machine Contexts | |||
| //! State machines have access to both a [global context](sm::GlobalContext) as | |||
| //! well as to a [module-specific context](module::ClientModule::context). | |||
| //! State machines have access to both a [global | |||
There was a problem hiding this comment.
Autoformatter insists. I kind of don't care.
dpc
commented
Feb 3, 2024
| @@ -707,22 +698,22 @@ impl ExecutorBuilder { | |||
|
|
|||
| /// A state that is able to make progress eventually | |||
| #[derive(Debug)] | |||
| pub struct ActiveStateKey<GC> { | |||
elsirion
approved these changes
Feb 3, 2024
m1sterc001guy
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a simple developer. I see a "GC" I find the way to get rid of it.
https://www.reddit.com/r/rustjerk/comments/n8b09i/ron_swanson_on_garbage_collection/