Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ln-client): improve logging when choosing gateway #4229

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

elsirion
Copy link
Contributor

@elsirion elsirion commented Feb 4, 2024

Fixes #4194

maan2003
maan2003 previously approved these changes Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5a941b7) 57.94% compared to head (54de585) 57.92%.
Report is 2 commits behind head on master.

Files Patch % Lines
modules/fedimint-ln-client/src/lib.rs 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4229      +/-   ##
==========================================
- Coverage   57.94%   57.92%   -0.02%     
==========================================
  Files         197      197              
  Lines       43414    43418       +4     
==========================================
- Hits        25157    25152       -5     
- Misses      18257    18266       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elsirion elsirion marked this pull request as ready for review February 4, 2024 14:07
@elsirion elsirion requested a review from a team as a code owner February 4, 2024 14:07
@dpc dpc added this pull request to the merge queue Feb 5, 2024
Merged via the queue into fedimint:master with commit 900637a Feb 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log should tell which gateway was chosen
5 participants