feat(mint-client): include federation join info in OOBNotes
#4231
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4231 +/- ##
==========================================
+ Coverage 57.94% 58.05% +0.10%
==========================================
Files 197 197
Lines 43414 43563 +149
==========================================
+ Hits 25157 25290 +133
- Misses 18257 18273 +16 ☔ View full report in Codecov by Sentry. |
| @@ -110,11 +119,25 @@ impl OOBNotes { | |||
| ]) | |||
| } | |||
|
|
|||
| pub fn new_with_invite(notes: TieredMulti<SpendableNote>, invite: InviteCode) -> Self { | |||
| Self(vec
There was a problem hiding this comment.
maybe FIXME(0.2) so we can grep for it later
| @@ -92,6 +93,14 @@ pub struct OOBNotes(Vec<OOBNotesData>); | |||
| enum OOBNotesData { | |||
| let cfg = self.get_config().global; | ||
| let (any_guardian_id, any_guardian_url) = cfg | ||
| .api_endpoints | ||
| .iter() | ||
| .next() | ||
| .expect("A federation always has at least one guardian"); | ||
| InviteCode::new( | ||
| any_guardian_url.url.clone(), | ||
| *any_guardian_id, | ||
| cfg.federation_id(), | ||
| ) |
There was a problem hiding this comment.
would be nice to also have this function on config type
| /// Invite code to join the federation by which the e-cash was issued | ||
| /// | ||
| /// Introduce in 0.3.0 | ||
| Invite { |
There was a problem hiding this comment.
If this is present the FederationIdPrefix is redundant, though we might start to omit it in some future. Though we might already change code that uses FederationIdPrefix to use see if Invite is available.
There was a problem hiding this comment.
Is this a documentation request?
There was a problem hiding this comment.
No. Code request, unless I'm missing something.
| pub fn federation_id_prefix(&self) -> FederationIdPrefix { | ||
| self.0 | ||
| .iter() | ||
| .find_map(|data| match data { | ||
| OOBNotesData::FederationIdPrefix(prefix) => Some(*prefix), | ||
| OOBNotesData::Invite { federation_id, .. } => Some(federation_id.to_prefix()), |
There was a problem hiding this comment.
@dpc feels like this is what you were asking for in your comment?
Fixes #4048