chore: improve devimint api #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4237 +/- ##
=======================================
Coverage 57.87% 57.87%
=======================================
Files 197 197
Lines 43416 43420 +4
=======================================
+ Hits 25126 25129 +3
- Misses 18290 18291 +1 ☔ View full report in Codecov by Sentry. |
dpc
reviewed
Feb 5, 2024
| @@ -32,17 +32,19 @@ use super::vars::utf8; | |||
| use crate::util::{poll, FedimintdCmd}; | |||
| use crate::{poll_eq, vars}; | |||
|
|
|||
| #[derive(Clone)] | |||
| pub struct Federation { | |||
There was a problem hiding this comment.
Does it make sense to clone this? Isn't it more like a ... resource?
There was a problem hiding this comment.
all daemon structs are clone in devimint
There was a problem hiding this comment.
We don't do things like "kill on Drop" etc. on them?
There was a problem hiding this comment.
that happens in ProcessHandle, which is Arc<ProcessHandleInner>
dpc
approved these changes
Feb 5, 2024
elsirion
approved these changes
Feb 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.