chore(ci): test dev shell building #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| continue-on-error: true | ||
|
|
||
| - name: Build dev shell | ||
| if: github.event_name != 'pull_request' || matrix.build-in-pr |
There was a problem hiding this comment.
Looks like this takes ~1m in CI. Would it make sense to instead only run in the merge queue?
There was a problem hiding this comment.
I already disabled macos one in PRs, but I guess I don't really care that much about Linux one as well - as long as master doesn't have a broken dev shell it's OK. And it barely ever happens anyway.
dpc
force-pushed
the
24-02-06-test-dev-shells
branch
from
acede57
to
a9dec97
Compare
bradleystachurski
approved these changes
Feb 7, 2024
|
For future reference, this job should prevent these types of issues: #4217 |
elsirion
approved these changes
Feb 7, 2024
|
Thanks @dpc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.