feat: decoding of url-safe base64 encoding for oobnotes #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help the transition, we first implement decoding of url-safe base64 version (accepting both that and old version) and after a while we'll switch the encoding to url-safe one. Re fedimint#4040
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4259 +/- ##
==========================================
+ Coverage 58.06% 58.09% +0.02%
==========================================
Files 197 197
Lines 43700 43702 +2
==========================================
+ Hits 25376 25390 +14
+ Misses 18324 18312 -12 ☔ View full report in Codecov by Sentry. |
elsirion
approved these changes
Feb 7, 2024
Comment on lines
+241
to
+245
| let bytes = if let Ok(bytes) = BASE64_URL_SAFE.decode(s) { | ||
| bytes | ||
| } else { | ||
| base64::engine::general_purpose::STANDARD.decode(s)? | ||
| }; |
There was a problem hiding this comment.
Looked at the standard and there seems to be no case where there is a valid non-URL-safe base64 string that is also a valid url-safe base64 string encoding different data.
|
Let's backport so we can make the window between introducing decoding and switching encoding longer/allow earlier switching without breaking backwards compat guarantees. |
|
I see you were already a step ahead 😆 #4260 |
maan2003
approved these changes
Feb 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help the transition, we first implement decoding of url-safe base64 version (accepting both that and old version) and after a while we'll switch the encoding to url-safe one.
Re #4040