fix: remove random timeout from download of client config

[joschisan]

We remove the timeout since this is the only place were we use such a timeout and therefore its unexpected behaviour, especially in a generally async system. If we want to timeout the download of the client config we should do so explicitly by wrapping either try_download_client_config or FederationInfo::from_invite_code with a timeout instead of somewhere in the middle.

[elsirion]

How can we test this? Wasn't there another draft PR that replicated the slowness? Maybe that replication can be cherry-picked here now that it's being fixed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7245b06) 58.06% compared to head (3086518) 58.01%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4261      +/-   ##
==========================================
- Coverage   58.06%   58.01%   -0.06%     
==========================================
  Files         197      197              
  Lines       43700    43678      -22     
==========================================
- Hits        25376    25340      -36     
- Misses      18324    18338      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[justinmoon]

How can we test this? Wasn't there another draft PR that replicated the slowness? Maybe that replication can be cherry-picked here now that it's being fixed.

#4226 ?