fix: document consensus #4270
Merged
fix: document consensus #4270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4270 +/- ##
==========================================
- Coverage 58.06% 58.04% -0.03%
==========================================
Files 197 197
Lines 43700 43704 +4
==========================================
- Hits 25376 25366 -10
- Misses 18324 18338 +14 ☔ View full report in Codecov by Sentry. |
elsirion
approved these changes
Feb 8, 2024
| let (processed, unprocessed) = signed_session_outcome | ||
| .session_outcome | ||
| .items | ||
| .split_at(pending_accepted_items.len()); | ||
|
|
||
| assert!(processed.iter().eq(pending_accepted_items.iter())); |
There was a problem hiding this comment.
I think a message in that assert (that gets shown in the panic if it fails) would also be nice
|
I took one note in our call today that |
dpc
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.