fix: switch back to nix build for release builds on master
#4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For these we do want to produce the final binary every time, and their runtime is not as important. Re fedimint#4258
It sometimes can take a while.
bradleystachurski
approved these changes
Feb 13, 2024
| @@ -444,7 +452,7 @@ jobs: | |||
| run: | | |||
| bins="${{ matrix.build.bins }}" | |||
| for bin in ${bins//,/ } ; do | |||
| nix run "github:Mic92/nix-fast-build?rev=4376b8a33b217ee2f78ba3dcff01a3e464d13a46" -- --skip-cached --no-nom --flake .#legacyPackages.$(nix eval --raw --impure --expr builtins.currentSystem).$bin && sha256sum "./result/bin/$bin" | |||
| nix build .#$bin && sha256sum "./result/bin/$bin" | |||
There was a problem hiding this comment.
Is this step meant to have a test similar to the check versions step above? I believe this only prints the sha256 hash without comparing.
bin=fedimint-cli
nix build .#$bin && sha256sum "./result/bin/$bin"
20e9140fd21367f8b53f6a26f2a75bcf7191b5124058722c3f991e3e4e1b8e58 ./result/bin/fedimint-cli
There was a problem hiding this comment.
It's only for printing, so one can take it from CI output and compare with a local build.
justinmoon
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For these we do want to produce the final binary every time, and their runtime is not as important.
Re #4258