Gatewayd migrations #4327
Gatewayd migrations #4327
Conversation
m1sterc001guy
force-pushed
the
gatewayd_migrations
branch
from
2309f43
to
d60fce6
Compare
| #[repr(u8)] | ||
| #[derive(Clone, EnumIter, Debug)] | ||
| pub enum DbKeyPrefix { | ||
| FederationConfig = 0x04, | ||
| FederationRegistration = 0x05, |
There was a problem hiding this comment.
This isn't used anywhere in the codebase and hasn't for sometime. I think it should be safe to remove.
There was a problem hiding this comment.
Was the key present in 0.2? If so I'd want a migration that deletes old data with that key prefix. I wouldn't bother to check probably and just add a migration, should be easy enough in this case.
There was a problem hiding this comment.
No, this key was not preset in 0.2
There was a problem hiding this comment.
@benthecarman I think you guys were running master in some cases, be advised that this might make the gateway blow up in the future. We only aim to achieve compatibility between released versions.
There was a problem hiding this comment.
We're running 0.2.2, thanks for the call out though
There was a problem hiding this comment.
Great! Then I just misremembered :)
| #[repr(u8)] | ||
| #[derive(Clone, EnumIter, Debug)] | ||
| pub enum DbKeyPrefix { | ||
| FederationConfig = 0x04, | ||
| FederationRegistration = 0x05, |
There was a problem hiding this comment.
Was the key present in 0.2? If so I'd want a migration that deletes old data with that key prefix. I wouldn't bother to check probably and just add a migration, should be easy enough in this case.
Builds on #4282
Adds database snapshots for gatewayd and database migrations.