fix(memdb): waaay too slow, at least use rwlock #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a lot of debuging I discovered that some flakes are due to all the slowness of `MemDatabase`. On an even ligthly filled test database, coping all the data start taking considerable amount of time (single digit milliseconds), which combined with number of database transactions being opened and commited, can lead to quite long delays in processing in random places (as ordering of locking is somewhat arbitrary). It's possible that something is also running db transactions in a tight loop somwhere. For time being using an `RwLock` helps considerably, as all db transactions at least need to start, and we do two copied of the database content there, so being able to do it in parallel, significantly improves the throughput.
This was referenced Feb 15, 2024
|
#4335 even better, I hope. |
joschisan
approved these changes
Feb 15, 2024
maan2003
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
fix(memdb): waaay too slow, at least use rwlock
Perhaps we should re-prioritize looking into SurrealDB as a replacement https://github.com/surrealdb/surrealkv |
m1sterc001guy
approved these changes
Feb 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
dpc
added a commit
to dpc/fedimint
that referenced
this pull request
Feb 15, 2024
Backport fedimint#4329
|
Longer-term we might want a copy-on-write map type? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of debuging I discovered that some flakes are due to all the slowness of
MemDatabase.On an even ligthly filled test database, coping all the data start taking considerable amount of time (single digit milliseconds), which combined with number of database transactions being opened and commited, can lead to quite long delays in processing in random places (as ordering of locking is somewhat arbitrary).
It's possible that something is also running db transactions in a tight loop somwhere.
For time being using an
RwLockhelps considerably, as all db transactions at least need to start, and we do two copied of the database content there, so being able to do it in parallel, significantly improves the throughput.Having said that, current implementation is not practical for any production use, I'm afraid.