chore: add highest-level logs to sends_ecash_out_of_band #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO we should be doing it in every test, so I'm going to show it around. When you are debugging a tricky problem by analyzing thousands of logs lines of a failing test, having some reference points telling you where the highest level points of test execution happened is very, very useful. Prefixing them with `###`, it makes jumping around and finding them easier.
m1sterc001guy
approved these changes
Feb 15, 2024
bradleystachurski
approved these changes
Feb 15, 2024
|
I like this idea. It can be hard to tell what failed in CI runs. This should help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO we should be doing it in every test, so I'm going to show it around.
When you are debugging a tricky problem by analyzing thousands of logs lines of a failing test, having some reference points telling you where the highest level points of test execution happened is very, very useful.
Prefixing them with
###, it makes jumping around and finding them easier.