feat: simple release signing system #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
force-pushed
the
24-02-15-sign-releases
branch
from
a2bf5b4
to
fe400ba
Compare
Use `just sign-release v0.2.2` to sign the release. <prefix>-SHA256SUM and <prefix>-SHA256SUMS.asc are meant to be checked in.
dpc
force-pushed
the
24-02-15-sign-releases
branch
from
fe400ba
to
47afd09
Compare
elsirion
approved these changes
Feb 19, 2024
| @@ -0,0 +1,6 @@ | |||
| 716840cfe02a270aff5bf1a02eda9c87946af231ad4ca5796a981ed0d9b1723f v0.2.2-x86_64-linux/fedimint-cli | |||
There was a problem hiding this comment.
I'm getting the same hashes
elsirion
reviewed
Feb 19, 2024
| @@ -0,0 +1 @@ | |||
| !/bins | |||
There was a problem hiding this comment.
Somehow this doesn't work for me? I'm getting
$ git status
HEAD detached at pr/4339/head
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: v0.2.2-x86_64-linux.SHA256SUMS.asc
Untracked files:
(use "git add <file>..." to include in what will be committed)
bins/
no changes added to commit (use "git add" and/or "git commit -a")
There was a problem hiding this comment.
My git status has the bins under releases/bins, which is still showing up untracked in git
m1sterc001guy
approved these changes
Feb 20, 2024
elsirion
reviewed
Feb 20, 2024
|
|
||
| >&2 echo "Building..." | ||
| for out in fedimint-pkgs gateway-pkgs ; do | ||
| nix build "git+file:.?ref=refs/tags/${tag}#${out}" |
There was a problem hiding this comment.
I was wondering why we aren't using this build command in the context of #4305, but would these binaries run on non-nix systems? I doubt it and that's why we use bundlers. We should probably rather sign the bundler-generated binaries that we actually publish.
There was a problem hiding this comment.
Unclear if these binaries are reproducible but let's try. :D
dpc
added a commit
to dpc/fedimint
that referenced
this pull request
Feb 20, 2024
dpc
added a commit
to dpc/fedimint
that referenced
this pull request
Feb 20, 2024
dpc
added a commit
to dpc/fedimint
that referenced
this pull request
Feb 20, 2024
dpc
added a commit
to dpc/fedimint
that referenced
this pull request
Feb 20, 2024
dpc
added a commit
to dpc/fedimint
that referenced
this pull request
Feb 21, 2024
dpc
added a commit
to dpc/fedimint
that referenced
this pull request
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
just sign-release v0.2.2to sign the release.<prefix>-SHA256SUMand<prefix>-SHA256SUMS.ascare meant to be checked in.Now we get to (hopefully 馃) rip the benefits of Nix. We don't need the CI to sign anything, and anyone can verify and sign the release independently from the comfort of their personal terminal.
For reviewers:
We can iterate from here
Immediate follow-ups: