chore: remove unneeded usage of pub throughout gateway code
#4357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolk131
changed the title
pub throughout gateway code
tvolk131
changed the title
pub throughout gateway codepub throughout gateway code
elsirion
previously approved these changes
Feb 20, 2024
There was a problem hiding this comment.
I think in this case it's ok to reduce visibility, but @douglaz made a good point yesterday that making things pub again when needed is a lengthy process. So maybe for now we only want to make things private where it's necessary for guaranteeing invariants.
| @@ -1165,7 +1165,7 @@ impl Gateway { | |||
| /// - `GatewayConfiguration` is read from the database. | |||
| /// - All cli or environment variables are set such that we can create a | |||
| /// `GatewayConfiguration` | |||
| pub async fn get_gateway_configuration(&self) -> Option<GatewayConfiguration> { | |||
| async fn get_gateway_configuration(&self) -> Option<GatewayConfiguration> { | |||
There was a problem hiding this comment.
Is this something you might want to call if you instantiate the gateway yourself as part of a custom binary?
There was a problem hiding this comment.
I'd say yes, but right now I don't see us supporting custom binaries for gateways
| @@ -240,7 +239,7 @@ impl ClientModule for GatewayClientModule { | |||
| } | |||
|
|
|||
| impl GatewayClientModule { | |||
| pub fn to_gateway_registration_info( | |||
| fn to_gateway_registration_info( | |||
There was a problem hiding this comment.
Maybe useful for integrators
|
@douglaz do you think this PR is worth it? If so it needs a rebase. |
|
Rebased! |
elsirion
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.