Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add single peer request strategy #4361

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

m1sterc001guy
Copy link
Contributor

For the module I am working on, I have the need to submit an authenticated API request to a single peer. In this context, the client is authenticated with a single guardian, but should not have authenticated access to other guardians. For my module, this instructs the guardian to submit a consensus item.

Right now I don't think this is possible to do since request_with_strategy by default contacts all guardians.

@m1sterc001guy m1sterc001guy requested a review from a team as a code owner February 19, 2024 15:51
Copy link
Contributor

@elsirion elsirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we replace WsAdminClient with this eventually?

@m1sterc001guy
Copy link
Contributor Author

Could we replace WsAdminClient with this eventually?

Hmm it appears that WsAdminClient uses request_current_consensus underneath, which I'm a little confused about, since I thought authenticated APIs should only request a single guardian. I must be missing something about how WsAdminClient is used, maybe someone else can comment

@elsirion
Copy link
Contributor

I think it's always initialized with exactly one peer/API endpoint 🙈

@dpc dpc added this pull request to the merge queue Feb 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 21, 2024
@dpc dpc added this pull request to the merge queue Feb 21, 2024
Merged via the queue into fedimint:master with commit d7cc800 Feb 21, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants