feat: remove gateway from federation #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1sterc001guy
changed the title
elsirion
requested changes
Feb 20, 2024
elsirion
previously approved these changes
Feb 21, 2024
m1sterc001guy
force-pushed
the
remove_registration2
branch
from
19c4b40
to
de3ee23
Compare
elsirion
previously approved these changes
Feb 22, 2024
m1sterc001guy
force-pushed
the
remove_registration2
branch
from
de3ee23
to
5b6efee
Compare
dpc
approved these changes
Feb 27, 2024
elsirion
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4027
Adds a challenge-response protocol for removing gateway registrations from federations.
Challenge is the sha256 hash of bytes. This ensures that the challenge changes every time the gateway is re-registered. It also ensures that each guardian has its own challenge.
Gateways since with their private key (public key is the
gateway_id).