refactor: remove register_with_federation_inner #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsirion
approved these changes
Feb 21, 2024
| } | ||
| let federation_id = self.client_ctx.get_config().global.federation_id(); | ||
| self.module_api.register_gateway(®istration_info).await?; | ||
| debug!("Successfully registered gateway {gateway_id} with federation {federation_id}"); |
There was a problem hiding this comment.
nit: in the future we can use such refactors to move away from string interpolation to … whatever we call this syntax:
debug!(%gateway_id, %federation_id, "Successfully registered gateway with federation");
justinmoon
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we removed the client extension traits we no longer need to use the inner pattern here.