fix: flaky latency test #4381
Merged
fix: flaky latency test #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failing assertion compare max latency vs p90. But after improvements to client sm executor all the averages, mins, median and p90 went down. I don't see why some rare max timing would neccessarily need to be within any range compared to p90. Especially given how many tests we're running in parallel on a VM, etc.
bradleystachurski
approved these changes
Feb 21, 2024
maan2003
approved these changes
Feb 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Our old friend 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing assertion compare max latency vs p90. But after improvements to client sm executor all the averages, mins, median and p90 went down.
I don't see why some rare max timing would neccessarily need to be within any range compared to p90. Especially given how many tests we're running in parallel on a VM, etc.