Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devimint): print out stderr of commands we're running #4391

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Feb 22, 2024

I find logs of commands used by devimint as useful (if not more) than the logs of devimint itself.

@dpc dpc requested a review from a team as a code owner February 22, 2024 05:20
@justinmoon justinmoon added this pull request to the merge queue Feb 22, 2024
Merged via the queue into fedimint:master with commit 209c2f0 Feb 22, 2024
20 checks passed
@bradleystachurski
Copy link
Member

@dpc I think this is useful and we shouldn't revert, but I'm having trouble finding a way to programmatically parse the output of stderr in devimint tests. Did you happen to see a way we could both log stderr and still capture in output?

@dpc
Copy link
Contributor Author

dpc commented Mar 13, 2024

@bradleystachurski We should not need to parse stderr of commands, at least commonly. If you really do need it, you could just not use the macro and the method under the hood, and configure tokio::process::Command ad-hoc. Or possibly we could have another macro and/or function for it.

@bradleystachurski
Copy link
Member

@dpc Sounds good, I should have a PR up soon with an approach that lets us eat our stderr and have it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants