Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prevent hanging connnections failing builds #4401

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Feb 22, 2024

Stuff like this: https://github.com/fedimint/fedimint/actions/runs/8011581330/job/21885131838 , hangs on downloading something and must not be doing any progress.

It's better for nix to timeout and retry connection.

@dpc dpc marked this pull request as ready for review February 22, 2024 23:55
@dpc dpc requested a review from a team as a code owner February 22, 2024 23:55
Copy link
Member

@bradleystachurski bradleystachurski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a config option for connection-timeout. Perhaps this should use connect-timeout?

https://nixos.org/manual/nix/stable/command-ref/conf-file#conf-connect-timeout

@dpc dpc force-pushed the 24-02-22-nix-connection-timeout branch from 1b45a67 to 9af9a6a Compare February 23, 2024 01:49
@dpc
Copy link
Contributor Author

dpc commented Feb 23, 2024

I couldn't find a config option for connection-timeout. Perhaps this should use connect-timeout?

You save the day.

Copy link
Contributor

@justinmoon justinmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpc dpc enabled auto-merge February 23, 2024 02:28
@dpc dpc added this pull request to the merge queue Feb 23, 2024
Merged via the queue into fedimint:master with commit 1a25a03 Feb 23, 2024
20 checks passed
@dpc dpc deleted the 24-02-22-nix-connection-timeout branch February 23, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants