chore(mint-client): test parallel spends and reissuances #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsirion
force-pushed
the
2024-02-test-parallel-client
branch
2 times, most recently
from
00a32c9
to
bddd467
Compare
dpc
reviewed
Feb 25, 2024
| })); | ||
| } | ||
|
|
||
| let note_bags = futures::stream::iter(spend_tasks) |
dpc
previously approved these changes
Feb 25, 2024
maan2003
previously approved these changes
Feb 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I wonder why the linter didn't fail on the PR, will fix tomorrow. |
Landed after what your change is on top of, I guess. |
|
@elsirion We land? |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
elsirion
force-pushed
the
2024-02-test-parallel-client
branch
from
bddd467
to
d5ce14f
Compare
elsirion
dismissed stale reviews from maan2003, justinmoon, and dpc
via
37a9731
elsirion
force-pushed
the
2024-02-test-parallel-client
branch
from
d5ce14f
to
37a9731
Compare
|
There actually was something to fix. |
dpc
previously approved these changes
Feb 28, 2024
|
@elsirion Still seems to be. :D |
elsirion
force-pushed
the
2024-02-test-parallel-client
branch
from
37a9731
to
b939ec0
Compare
|
Yeah, forgot to run clippy with the extra command line options … |
bradleystachurski
previously approved these changes
Feb 29, 2024
elsirion
force-pushed
the
2024-02-test-parallel-client
branch
from
b939ec0
to
970ecf1
Compare
bradleystachurski
approved these changes
Feb 29, 2024
dpc
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3988. Note that using
MemDatabasestill leads to deadlocks, but that's not production-ready anyway, so we can track it independently.