chore: add blank .semgrepignore & fix findings #4417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed |
If .semgrepignore is not present, semgrep uses a default .semgrepignore file. The defaults excluded some tests which is not the desired outcome. Add a blank .semgrepignore file to indicate that nothing additional to .gitignore should be ignored by semgrep. Also, add a second pattern to ban-direct-sleep-in-tests rule to find the sleep function when the fully qualified function name is present.
kernelkind
force-pushed
the
semgrep_fix
branch
from
a66675a
to
680bc59
Compare
dpc
approved these changes
Feb 26, 2024
elsirion
approved these changes
Feb 26, 2024
|
Good catch, thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If .semgrepignore is not present, semgrep uses a default .semgrepignore file. The defaults excluded some tests which is not the desired outcome.
Add a blank .semgrepignore file to indicate that nothing additional to .gitignore should be ignored by semgrep.
Also, add a second pattern to ban-direct-sleep-in-tests rule to find the sleep function when the fully qualified function name is present.